diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-05-26 08:45:42 +0200 |
|---|---|---|
| committer | MyungJoo Ham <myungjoo.ham@samsung.com> | 2016-06-22 06:52:55 +0200 |
| commit | 674789dd2c4b53ed368dc81ae22d72ac4fdb92ec (patch) | |
| tree | 85a614f26acb314ff5325fb0f9b4ea10f954a86a | |
| parent | PM / devfreq: remove double put_device (diff) | |
| download | linux-674789dd2c4b53ed368dc81ae22d72ac4fdb92ec.tar.xz linux-674789dd2c4b53ed368dc81ae22d72ac4fdb92ec.zip | |
PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check
Smatch complains because platform_get_resource() returns NULL on error
and not an error pointer so the check is wrong. Julia Lawall pointed
out that normally we don't check these, because devm_ioremap_resource()
has a check for NULL.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
| -rw-r--r-- | drivers/devfreq/event/exynos-nocp.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c index 6b6a5f310486..a5841403bde8 100644 --- a/drivers/devfreq/event/exynos-nocp.c +++ b/drivers/devfreq/event/exynos-nocp.c @@ -220,9 +220,6 @@ static int exynos_nocp_parse_dt(struct platform_device *pdev, /* Maps the memory mapped IO to control nocp register */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (IS_ERR(res)) - return PTR_ERR(res); - base = devm_ioremap_resource(dev, res); if (IS_ERR(base)) return PTR_ERR(base); |