diff options
| author | Vasily Averin <vvs@virtuozzo.com> | 2018-11-03 21:22:10 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2018-11-03 21:22:10 +0100 |
| commit | cea5794122125bf67559906a0762186cf417099c (patch) | |
| tree | e6a9d844d2cf1b9d59d841aeb6c51e3c656ea43e | |
| parent | ext4: avoid potential extra brelse in setup_new_flex_group_blocks() (diff) | |
| download | linux-cea5794122125bf67559906a0762186cf417099c.tar.xz linux-cea5794122125bf67559906a0762186cf417099c.zip | |
ext4: add missing brelse() in set_flexbg_block_bitmap()'s error path
Fixes: 33afdcc5402d ("ext4: add a function which sets up group blocks ...")
Cc: stable@kernel.org # 3.3
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/resize.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index c3fa30878ca8..0a4dc6217e78 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -459,16 +459,18 @@ static int set_flexbg_block_bitmap(struct super_block *sb, handle_t *handle, BUFFER_TRACE(bh, "get_write_access"); err = ext4_journal_get_write_access(handle, bh); - if (err) + if (err) { + brelse(bh); return err; + } ext4_debug("mark block bitmap %#04llx (+%llu/%u)\n", first_cluster, first_cluster - start, count2); ext4_set_bits(bh->b_data, first_cluster - start, count2); err = ext4_handle_dirty_metadata(handle, NULL, bh); + brelse(bh); if (unlikely(err)) return err; - brelse(bh); } return 0; |