summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-08-08 21:16:42 +0200
committerJonathan Cameron <jic23@kernel.org>2015-10-03 11:28:24 +0200
commiteda7d0f38aaf50dbb2a2de15e8db386c4f6f65fc (patch)
tree4539f2e5a45ebfd1c861adf5144b179450c6ca47
parentiio: st_accel: fix interrupt handling on LIS3LV02 (diff)
downloadlinux-eda7d0f38aaf50dbb2a2de15e8db386c4f6f65fc.tar.xz
linux-eda7d0f38aaf50dbb2a2de15e8db386c4f6f65fc.zip
iio: accel: sca3000: memory corruption in sca3000_read_first_n_hw_rb()
"num_read" is in byte units but we are write u16s so we end up write twice as much as intended. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
-rw-r--r--drivers/staging/iio/accel/sca3000_ring.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
index 23685e74917e..bd2c69f85949 100644
--- a/drivers/staging/iio/accel/sca3000_ring.c
+++ b/drivers/staging/iio/accel/sca3000_ring.c
@@ -116,7 +116,7 @@ static int sca3000_read_first_n_hw_rb(struct iio_buffer *r,
if (ret)
goto error_ret;
- for (i = 0; i < num_read; i++)
+ for (i = 0; i < num_read / sizeof(u16); i++)
*(((u16 *)rx) + i) = be16_to_cpup((__be16 *)rx + i);
if (copy_to_user(buf, rx, num_read))