diff options
author | Steven Rostedt <srostedt@redhat.com> | 2009-08-07 01:53:18 +0200 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-08-07 08:50:29 +0200 |
commit | 7dbdee2e9a2ac42ea5135801bcc9d1a8e3f672aa (patch) | |
tree | df94010b7388d14432269c0dfa958b9ca4b86a4b | |
parent | ring-buffer: Fix advance of reader in rb_buffer_peek() (diff) | |
download | linux-7dbdee2e9a2ac42ea5135801bcc9d1a8e3f672aa.tar.xz linux-7dbdee2e9a2ac42ea5135801bcc9d1a8e3f672aa.zip |
tracing: Fix recordmcount.pl to handle sections with only weak functions
Roland Dreier found that a section that contained only a weak
function in one of the staging drivers and this caused
recordmcount.pl to spit out a warning and fail.
Although it is strange that a driver would have a weak function, and
this function only be used in one place, it should not be something
to make recordmcount.pl fail.
This patch fixes the issue in a simple manner: if only weak
functions exist in a section, then that section will not be
recorded.
Reported-by: Roland Dreier <rdreier@cisco.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rwxr-xr-x | scripts/recordmcount.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl index 4889c44d71b5..911ba7ffab84 100755 --- a/scripts/recordmcount.pl +++ b/scripts/recordmcount.pl @@ -393,7 +393,7 @@ while (<IN>) { $read_function = 0; } # print out any recorded offsets - update_funcs() if ($text_found); + update_funcs() if (defined($ref_func)); # reset all markers and arrays $text_found = 0; @@ -444,7 +444,7 @@ while (<IN>) { } # dump out anymore offsets that may have been found -update_funcs() if ($text_found); +update_funcs() if (defined($ref_func)); # If we did not find any mcount callers, we are done (do nothing). if (!$opened) { |