diff options
| author | Koul, Vinod <vinod.koul@intel.com> | 2010-10-04 12:38:25 +0200 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2010-10-08 00:03:43 +0200 |
| commit | 8b6492231d2a92352a6371eebd622e3bc824a663 (patch) | |
| tree | 875a69042151b5c317a9dc4b89a63bbbfbd5c834 | |
| parent | intel_mid_dma: Add sg list support to DMA driver (diff) | |
| download | linux-8b6492231d2a92352a6371eebd622e3bc824a663.tar.xz linux-8b6492231d2a92352a6371eebd622e3bc824a663.zip | |
intel_mid_dma: fix the WARN_ONs
Moved the WARN_ON to BUG_ON, as WARN_ON if hit,
can cause null pointer derefrences
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
| -rw-r--r-- | drivers/dma/intel_mid_dma.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c index 2ae1086b9481..ef7ffb813fe9 100644 --- a/drivers/dma/intel_mid_dma.c +++ b/drivers/dma/intel_mid_dma.c @@ -581,15 +581,15 @@ static struct dma_async_tx_descriptor *intel_mid_dma_prep_memcpy( enum intel_mid_dma_width width = 0; pr_debug("MDMA: Prep for memcpy\n"); - WARN_ON(!chan); + BUG_ON(!chan); if (!len) return NULL; mids = chan->private; - WARN_ON(!mids); + BUG_ON(!mids); midc = to_intel_mid_dma_chan(chan); - WARN_ON(!midc); + BUG_ON(!midc); pr_debug("MDMA:called for DMA %x CH %d Length %zu\n", midc->dma->pci_id, midc->ch_id, len); |