summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWeston Andros Adamson <dros@primarydata.com>2014-11-03 21:19:45 +0100
committerTrond Myklebust <trond.myklebust@primarydata.com>2014-11-12 20:22:52 +0100
commit16c9914069536c77ed358d94b6e247bdc464b7f0 (patch)
treef9ce7b5a4824d8040bed2562236356db22130a96
parentpnfs/blocklayout: serialize GETDEVICEINFO calls (diff)
downloadlinux-16c9914069536c77ed358d94b6e247bdc464b7f0.tar.xz
linux-16c9914069536c77ed358d94b6e247bdc464b7f0.zip
nfs: remove spurious WARN_ON_ONCE in write path
This WARN_ON_ONCE was supposed to catch reference counting bugs, but can trigger in inappropriate situations. This was reproducible using NFSv2 on an architecture with 64K pages -- we verified that it was not a reference counting bug and the warning was safe to ignore. Reported-by: Will Deacon <will.deacon@arm.com> Tested-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Weston Andros Adamson <dros@primarydata.com> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
-rw-r--r--fs/nfs/write.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 12493846a2d3..f83b02dc9166 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -715,8 +715,6 @@ static void nfs_inode_remove_request(struct nfs_page *req)
if (test_and_clear_bit(PG_INODE_REF, &req->wb_flags))
nfs_release_request(req);
- else
- WARN_ON_ONCE(1);
}
static void