diff options
| author | Jan Kara <jack@suse.cz> | 2009-09-08 14:59:42 +0200 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2009-09-16 17:44:11 +0200 |
| commit | 56fcad29d4b3cbcbb2ed47a9d3ceca3f57175417 (patch) | |
| tree | 4ad4816b11706e350760a3e206126105a7bf9a5c | |
| parent | ext3: Add locking to ext3_do_update_inode (diff) | |
| download | linux-56fcad29d4b3cbcbb2ed47a9d3ceca3f57175417.tar.xz linux-56fcad29d4b3cbcbb2ed47a9d3ceca3f57175417.zip | |
ext3: Flush disk caches on fsync when needed
In case we fsync() a file and inode is not dirty, we don't force a transaction
to disk and hence don't flush disk caches. Thus file data could be just in disk
caches and not on persistent storage. Fix the problem by flushing disk caches
if we didn't force a transaction commit.
Signed-off-by: Jan Kara <jack@suse.cz>
| -rw-r--r-- | fs/ext3/fsync.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/fs/ext3/fsync.c b/fs/ext3/fsync.c index d33634119e17..451d166bbe93 100644 --- a/fs/ext3/fsync.c +++ b/fs/ext3/fsync.c @@ -23,6 +23,7 @@ */ #include <linux/time.h> +#include <linux/blkdev.h> #include <linux/fs.h> #include <linux/sched.h> #include <linux/writeback.h> @@ -73,7 +74,7 @@ int ext3_sync_file(struct file * file, struct dentry *dentry, int datasync) } if (datasync && !(inode->i_state & I_DIRTY_DATASYNC)) - goto out; + goto flush; /* * The VFS has written the file data. If the inode is unaltered @@ -85,7 +86,16 @@ int ext3_sync_file(struct file * file, struct dentry *dentry, int datasync) .nr_to_write = 0, /* sys_fsync did this */ }; ret = sync_inode(inode, &wbc); + goto out; } +flush: + /* + * In case we didn't commit a transaction, we have to flush + * disk caches manually so that data really is on persistent + * storage + */ + if (test_opt(inode->i_sb, BARRIER)) + blkdev_issue_flush(inode->i_sb->s_bdev, NULL); out: return ret; } |