diff options
| author | Eric Dumazet <edumazet@google.com> | 2012-06-03 21:50:43 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-06-04 17:27:39 +0200 |
| commit | 90ba9b1986b5ac4b2d184575847147ea7c4280a2 (patch) | |
| tree | 462289c5795f500049b83c2ccd96fa6b1586565e | |
| parent | Linux 3.5-rc1 (diff) | |
| download | linux-90ba9b1986b5ac4b2d184575847147ea7c4280a2.tar.xz linux-90ba9b1986b5ac4b2d184575847147ea7c4280a2.zip | |
tcp: tcp_make_synack() can use alloc_skb()
There is no value using sock_wmalloc() in tcp_make_synack().
A listener socket only sends SYNACK packets, they are not queued in a
socket queue, only in Qdisc and device layers, so the number of in
flight packets is limited in these layers. We used sock_wmalloc() with
the %force parameter set to 1 to ignore socket limits anyway.
This patch removes two atomic operations per SYNACK packet.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/tcp_output.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 803cbfe82fbc..f0b0e4414b00 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -2461,7 +2461,7 @@ struct sk_buff *tcp_make_synack(struct sock *sk, struct dst_entry *dst, if (cvp != NULL && cvp->s_data_constant && cvp->s_data_desired) s_data_desired = cvp->s_data_desired; - skb = sock_wmalloc(sk, MAX_TCP_HEADER + 15 + s_data_desired, 1, GFP_ATOMIC); + skb = alloc_skb(MAX_TCP_HEADER + 15 + s_data_desired, GFP_ATOMIC); if (skb == NULL) return NULL; |