diff options
| author | Akinobu Mita <akinobu.mita@gmail.com> | 2008-04-17 16:38:59 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2008-04-17 16:38:59 +0200 |
| commit | a871611b474bfcdee422c0cf5d16f509dce096f5 (patch) | |
| tree | a02ef4ea39365dca2bbf84d9db8656ee6f9feab2 | |
| parent | ext4: use ext4_get_group_desc() (diff) | |
| download | linux-a871611b474bfcdee422c0cf5d16f509dce096f5.tar.xz linux-a871611b474bfcdee422c0cf5d16f509dce096f5.zip | |
ext4: check ext4_journal_get_write_access() errors
Check ext4_journal_get_write_access() errors.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Stephen Tweedie <sct@redhat.com>
Cc: adilger@clusterfs.com
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Mingming Cao <cmm@us.ibm.com>
| -rw-r--r-- | fs/ext4/namei.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 68611945687d..63c33e053478 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -57,10 +57,15 @@ static struct buffer_head *ext4_append(handle_t *handle, *block = inode->i_size >> inode->i_sb->s_blocksize_bits; - if ((bh = ext4_bread(handle, inode, *block, 1, err))) { + bh = ext4_bread(handle, inode, *block, 1, err); + if (bh) { inode->i_size += inode->i_sb->s_blocksize; EXT4_I(inode)->i_disksize = inode->i_size; - ext4_journal_get_write_access(handle,bh); + *err = ext4_journal_get_write_access(handle, bh); + if (*err) { + brelse(bh); + bh = NULL; + } } return bh; } |