summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndy Grover <agrover@redhat.com>2014-07-01 01:39:43 +0200
committerNicholas Bellinger <nab@linux-iscsi.org>2014-10-01 23:38:41 +0200
commitcc83881f2c57caaf4b14adaffa65595640a59661 (patch)
treefc1bc9d52219265e5f82e15e6174ef46fe833971
parenttarget: fix unused shift in core_scsi3_pri_report_capabilities (diff)
downloadlinux-cc83881f2c57caaf4b14adaffa65595640a59661.tar.xz
linux-cc83881f2c57caaf4b14adaffa65595640a59661.zip
target: core_tpg_post_dellun can return void
Nothing in it can raise an error. Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Andy Grover <agrover@redhat.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
-rw-r--r--drivers/target/target_core_internal.h2
-rw-r--r--drivers/target/target_core_tpg.c4
2 files changed, 2 insertions, 4 deletions
diff --git a/drivers/target/target_core_internal.h b/drivers/target/target_core_internal.h
index de9cab708f45..463fddcd0ef6 100644
--- a/drivers/target/target_core_internal.h
+++ b/drivers/target/target_core_internal.h
@@ -83,7 +83,7 @@ struct se_lun *core_tpg_alloc_lun(struct se_portal_group *, u32);
int core_tpg_add_lun(struct se_portal_group *, struct se_lun *,
u32, struct se_device *);
struct se_lun *core_tpg_pre_dellun(struct se_portal_group *, u32 unpacked_lun);
-int core_tpg_post_dellun(struct se_portal_group *, struct se_lun *);
+void core_tpg_post_dellun(struct se_portal_group *, struct se_lun *);
/* target_core_transport.c */
extern struct kmem_cache *se_tmr_req_cache;
diff --git a/drivers/target/target_core_tpg.c b/drivers/target/target_core_tpg.c
index fddfae61222f..b596ab509197 100644
--- a/drivers/target/target_core_tpg.c
+++ b/drivers/target/target_core_tpg.c
@@ -867,7 +867,7 @@ struct se_lun *core_tpg_pre_dellun(
return lun;
}
-int core_tpg_post_dellun(
+void core_tpg_post_dellun(
struct se_portal_group *tpg,
struct se_lun *lun)
{
@@ -881,6 +881,4 @@ int core_tpg_post_dellun(
spin_unlock(&tpg->tpg_lun_lock);
percpu_ref_exit(&lun->lun_ref);
-
- return 0;
}