summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLatchesar Ionkov <lucho@ionkov.net>2007-10-23 20:48:33 +0200
committerEric Van Hensbergen <ericvh@gmail.com>2007-10-23 20:48:33 +0200
commit22150c4f0f02619c256f35db2f1ec912549b4ca5 (patch)
tree3afeade940b21ac5ba7534fe430086de15067d35
parent9p: fix memleak in fs/9p/v9fs.c (diff)
downloadlinux-22150c4f0f02619c256f35db2f1ec912549b4ca5.tar.xz
linux-22150c4f0f02619c256f35db2f1ec912549b4ca5.zip
9p: v9fs_vfs_rename incorrect clunk order
In v9fs_vfs_rename function labels don't match the fids that are clunked. The correct clunk order is clunking newdirfid first and then olddirfid next. Signed-off-by: Latchesar Ionkov <lucho@ionkov.net> Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
-rw-r--r--fs/9p/vfs_inode.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index 175b4d9bf3f8..23581bcb599b 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -687,10 +687,10 @@ v9fs_vfs_rename(struct inode *old_dir, struct dentry *old_dentry,
retval = p9_client_wstat(oldfid, &wstat);
clunk_newdir:
- p9_client_clunk(olddirfid);
+ p9_client_clunk(newdirfid);
clunk_olddir:
- p9_client_clunk(newdirfid);
+ p9_client_clunk(olddirfid);
done:
return retval;