diff options
| author | Valentine Barshak <vbarshak@ru.mvista.com> | 2008-04-03 21:09:43 +0200 |
|---|---|---|
| committer | Olof Johansson <olof@lixom.net> | 2008-04-07 16:16:29 +0200 |
| commit | 7132799b0e49c48cf119dbe02d20810860d20991 (patch) | |
| tree | bc57047cce9764081582aca08ccb393eee27753b | |
| parent | [POWERPC] pasemi: Minor iommu cleanup (diff) | |
| download | linux-7132799b0e49c48cf119dbe02d20810860d20991.tar.xz linux-7132799b0e49c48cf119dbe02d20810860d20991.zip | |
[POWERPC] kexec: MPIC ack interrupts at mpic_teardown_this_cpu()
We really need to ack interrupts at mpic_teardown, since
not all platforms reset mpic at kernel start-up. For example,
kexec'ed kernel hangs on P.A. Semi if mpic_eoi() isn't called.
Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
| -rw-r--r-- | arch/powerpc/sysdev/mpic.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c index 6131fd2b6619..8619f2a3f1f6 100644 --- a/arch/powerpc/sysdev/mpic.c +++ b/arch/powerpc/sysdev/mpic.c @@ -1410,11 +1410,6 @@ void mpic_cpu_set_priority(int prio) mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), prio); } -/* - * XXX: someone who knows mpic should check this. - * do we need to eoi the ipi including for kexec cpu here (see xics comments)? - * or can we reset the mpic in the new kernel? - */ void mpic_teardown_this_cpu(int secondary) { struct mpic *mpic = mpic_primary; @@ -1434,6 +1429,10 @@ void mpic_teardown_this_cpu(int secondary) /* Set current processor priority to max */ mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), 0xf); + /* We need to EOI the IPI since not all platforms reset the MPIC + * on boot and new interrupts wouldn't get delivered otherwise. + */ + mpic_eoi(mpic); spin_unlock_irqrestore(&mpic_lock, flags); } |