diff options
| author | Peter Hurley <peter@hurleysoftware.com> | 2013-03-05 07:09:06 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-03-06 08:47:04 +0100 |
| commit | 0b176ce3a7cbfa92eceddf3896f1a504877d974a (patch) | |
| tree | fe3b0e5154f51ba4a8a87dc6bd4dbd00e47270b6 | |
| parent | net/irda: Hold port lock while bumping blocked_open (diff) | |
| download | linux-0b176ce3a7cbfa92eceddf3896f1a504877d974a.tar.xz linux-0b176ce3a7cbfa92eceddf3896f1a504877d974a.zip | |
net/irda: Use barrier to set task state
Without a memory and compiler barrier, the task state change
can migrate relative to the condition testing in a blocking loop.
However, the task state change must be visible across all cpus
prior to testing those conditions. Failing to do this can result
in the familiar 'lost wakeup' and this task will hang until killed.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/irda/ircomm/ircomm_tty.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c index d282bbea710e..522543d9264a 100644 --- a/net/irda/ircomm/ircomm_tty.c +++ b/net/irda/ircomm/ircomm_tty.c @@ -324,7 +324,7 @@ static int ircomm_tty_block_til_ready(struct ircomm_tty_cb *self, if (tty->termios.c_cflag & CBAUD) tty_port_raise_dtr_rts(port); - current->state = TASK_INTERRUPTIBLE; + set_current_state(TASK_INTERRUPTIBLE); if (tty_hung_up_p(filp) || !test_bit(ASYNCB_INITIALIZED, &port->flags)) { |