summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Walleij <triad@df.lth.se>2008-10-24 22:17:50 +0200
committerRussell King <rmk+kernel@arm.linux.org.uk>2008-10-28 01:00:42 +0100
commit9e9430213f85ebdaf40026ec790295420efd0f91 (patch)
treef1e2ee98fade8b1c66c129f4b92dd00e9e06207e
parentMerge branch 'for-linus' of git://neil.brown.name/md (diff)
downloadlinux-9e9430213f85ebdaf40026ec790295420efd0f91.tar.xz
linux-9e9430213f85ebdaf40026ec790295420efd0f91.zip
[ARM] 5322/1: Fix fastpath issue in mmci.c
Fix fastpath issues Since mmci_request() can be called from a non-interrupt context, and does, during kernel init, causing a host of debug messages during boot if you enable spinlock debugging, we need to use the spinlock calls that save IRQ flags and restore them. Signed-off-by: Linus Walleij <triad@df.lth.se> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
-rw-r--r--drivers/mmc/host/mmci.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index 696cf3647ceb..2fadf323c696 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -391,6 +391,7 @@ static irqreturn_t mmci_irq(int irq, void *dev_id)
static void mmci_request(struct mmc_host *mmc, struct mmc_request *mrq)
{
struct mmci_host *host = mmc_priv(mmc);
+ unsigned long flags;
WARN_ON(host->mrq != NULL);
@@ -402,7 +403,7 @@ static void mmci_request(struct mmc_host *mmc, struct mmc_request *mrq)
return;
}
- spin_lock_irq(&host->lock);
+ spin_lock_irqsave(&host->lock, flags);
host->mrq = mrq;
@@ -411,7 +412,7 @@ static void mmci_request(struct mmc_host *mmc, struct mmc_request *mrq)
mmci_start_command(host, mrq->cmd, 0);
- spin_unlock_irq(&host->lock);
+ spin_unlock_irqrestore(&host->lock, flags);
}
static void mmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)