diff options
| author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2012-03-13 11:35:41 +0100 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2012-03-15 10:49:26 +0100 |
| commit | 1d97e9154821d52a5ebc226176d4839c7b86b116 (patch) | |
| tree | f2ca2239eb3b5b2e8d99bd0f8b656fb8dd6a7eac | |
| parent | drm: Warn if mode to umode conversion overflows the destination types (diff) | |
| download | linux-1d97e9154821d52a5ebc226176d4839c7b86b116.tar.xz linux-1d97e9154821d52a5ebc226176d4839c7b86b116.zip | |
drm: Check crtc x and y coordinates
The crtc x/y panning coordinates are stored as signed integers
internally. The user provides them as unsigned, so we should check
that the user provided values actually fit in the internal datatypes.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/drm_crtc.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index d11763f7211a..3a42c9cb0eb2 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -1774,6 +1774,10 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data, if (!drm_core_check_feature(dev, DRIVER_MODESET)) return -EINVAL; + /* For some reason crtc x/y offsets are signed internally. */ + if (crtc_req->x > INT_MAX || crtc_req->y > INT_MAX) + return -ERANGE; + mutex_lock(&dev->mode_config.mutex); obj = drm_mode_object_find(dev, crtc_req->crtc_id, DRM_MODE_OBJECT_CRTC); |