diff options
| author | Javier González <jg@lightnvm.io> | 2017-05-03 11:19:05 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2017-05-04 15:53:04 +0200 |
| commit | 507f7d68fe5c24973dcd6e48f011bdfbd2197f01 (patch) | |
| tree | e16f1c40edecd3d0cfc5a358cfafe58eba604708 | |
| parent | lightnvm: create cmd before allocating request (diff) | |
| download | linux-507f7d68fe5c24973dcd6e48f011bdfbd2197f01.tar.xz linux-507f7d68fe5c24973dcd6e48f011bdfbd2197f01.zip | |
lightnvm: fix bad back free on error path
Free memory correctly when an allocation fails on a loop and we free
backwards previously successful allocations.
Signed-off-by: Javier González <javier@cnexlabs.com>
Reviewed-by: Matias Bjørling <matias@cnexlabs.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
| -rw-r--r-- | drivers/lightnvm/core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index 54a06c3a2b8c..6a4aa608ad95 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -74,7 +74,7 @@ static int nvm_reserve_luns(struct nvm_dev *dev, int lun_begin, int lun_end) return 0; err: - while (--i > lun_begin) + while (--i >= lun_begin) clear_bit(i, dev->lun_map); return -EBUSY; @@ -211,7 +211,7 @@ static struct nvm_tgt_dev *nvm_create_tgt_dev(struct nvm_dev *dev, return tgt_dev; err_ch: - while (--i > 0) + while (--i >= 0) kfree(dev_map->chnls[i].lun_offs); kfree(luns); err_luns: |