diff options
| author | Thomas Meyer <thomas@m3y3r.de> | 2011-11-29 22:08:00 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2011-12-06 13:27:32 +0100 |
| commit | 6d2d4313690f2f81a9a54c6a0c8ae645c4598063 (patch) | |
| tree | 43b545d2d4818deadb08fd3a4b214fe5ec41dd85 | |
| parent | ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array (diff) | |
| download | linux-6d2d4313690f2f81a9a54c6a0c8ae645c4598063.tar.xz linux-6d2d4313690f2f81a9a54c6a0c8ae645c4598063.zip | |
ALSA: asihp: Use kcalloc instead of kzalloc to allocate array
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.
The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/pci/asihpi/hpicmn.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/asihpi/hpicmn.c b/sound/pci/asihpi/hpicmn.c index bd47521b24ec..44c7eb4a3f1d 100644 --- a/sound/pci/asihpi/hpicmn.c +++ b/sound/pci/asihpi/hpicmn.c @@ -631,7 +631,7 @@ struct hpi_control_cache *hpi_alloc_control_cache(const u32 control_count, if (!p_cache) return NULL; - p_cache->p_info = kzalloc(sizeof(*p_cache->p_info) * control_count, + p_cache->p_info = kcalloc(control_count, sizeof(*p_cache->p_info), GFP_KERNEL); if (!p_cache->p_info) { kfree(p_cache); |