summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2018-03-19 10:12:31 +0100
committerJohn Johansen <john.johansen@canonical.com>2018-03-24 01:28:38 +0100
commitd53c9f4d212c25b09670a71e2a993071d1e637a2 (patch)
tree187fbebda854a6541eb3f72bd316838779dc8a96
parentapparmor: fix error returns checks by making size a ssize_t (diff)
downloadlinux-d53c9f4d212c25b09670a71e2a993071d1e637a2.tar.xz
linux-d53c9f4d212c25b09670a71e2a993071d1e637a2.zip
apparmor: Fix an error code in verify_table_headers()
We accidentally return a positive EPROTO instead of a negative -EPROTO. Since 71 is not an error pointer, that means it eventually results in an Oops in the caller. Fixes: d901d6a298dc ("apparmor: dfa split verification of table headers") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: John Johansen <john.johansen@canonical.com>
-rw-r--r--security/apparmor/match.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/security/apparmor/match.c b/security/apparmor/match.c
index dd4c995c5e25..280eba082c7b 100644
--- a/security/apparmor/match.c
+++ b/security/apparmor/match.c
@@ -198,7 +198,7 @@ out:
static int verify_dfa(struct aa_dfa *dfa)
{
size_t i, state_count, trans_count;
- int error = EPROTO;
+ int error = -EPROTO;
state_count = dfa->tables[YYTD_ID_BASE]->td_lolen;
trans_count = dfa->tables[YYTD_ID_NXT]->td_lolen;