summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdrian Hunter <adrian.hunter@intel.com>2018-12-21 13:06:17 +0100
committerArnaldo Carvalho de Melo <acme@redhat.com>2019-01-02 14:53:41 +0100
commit2e9e8688763ff80f032d9a78c3b4b951fb6dd7a4 (patch)
tree77b8463daa23251b055a6075af1d556c322f4981
parentperf thread-stack: Allow for a thread stack array (diff)
downloadlinux-2e9e8688763ff80f032d9a78c3b4b951fb6dd7a4.tar.xz
linux-2e9e8688763ff80f032d9a78c3b4b951fb6dd7a4.zip
perf thread-stack: Factor out thread_stack__init()
In preparation for fixing thread stack processing for the idle task, factor out thread_stack__init(). Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Acked-by: Jiri Olsa <jolsa@kernel.org> Link: http://lkml.kernel.org/r/20181221120620.9659-6-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/util/thread-stack.c26
1 files changed, 19 insertions, 7 deletions
diff --git a/tools/perf/util/thread-stack.c b/tools/perf/util/thread-stack.c
index a5f7b9d8fc23..03770af9e5cd 100644
--- a/tools/perf/util/thread-stack.c
+++ b/tools/perf/util/thread-stack.c
@@ -93,6 +93,24 @@ static int thread_stack__grow(struct thread_stack *ts)
return 0;
}
+static int thread_stack__init(struct thread_stack *ts, struct thread *thread,
+ struct call_return_processor *crp)
+{
+ int err;
+
+ err = thread_stack__grow(ts);
+ if (err)
+ return err;
+
+ if (thread->mg && thread->mg->machine)
+ ts->kernel_start = machine__kernel_start(thread->mg->machine);
+ else
+ ts->kernel_start = 1ULL << 63;
+ ts->crp = crp;
+
+ return 0;
+}
+
static struct thread_stack *thread_stack__new(struct thread *thread,
struct call_return_processor *crp)
{
@@ -104,17 +122,11 @@ static struct thread_stack *thread_stack__new(struct thread *thread,
ts->arr_sz = 1;
- if (thread_stack__grow(ts)) {
+ if (thread_stack__init(ts, thread, crp)) {
free(ts);
return NULL;
}
- if (thread->mg && thread->mg->machine)
- ts->kernel_start = machine__kernel_start(thread->mg->machine);
- else
- ts->kernel_start = 1ULL << 63;
- ts->crp = crp;
-
thread->ts = ts;
return ts;