diff options
| author | Tejun Heo <tj@kernel.org> | 2008-11-13 05:20:00 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-01-06 19:44:31 +0100 |
| commit | c65b9145f40da99cad000f81823265dc70e5fcf9 (patch) | |
| tree | f26091022846aea449821b6c1acdbc46d75da6b1 | |
| parent | sysfs: clarify SYSFS_DEPRECATED help text (diff) | |
| download | linux-c65b9145f40da99cad000f81823265dc70e5fcf9.tar.xz linux-c65b9145f40da99cad000f81823265dc70e5fcf9.zip | |
uevent: don't pass envp_ext[] as format string in kobject_uevent_env()
kobject_uevent_env() uses envp_ext[] as verbatim format string which
can cause problems ranging from unexpectedly mangled string to oops if
a string in envp_ext[] contains substring which can be interpreted as
format. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | lib/kobject_uevent.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 3f914725bda8..ca215bc2329a 100644 --- a/lib/kobject_uevent.c +++ b/lib/kobject_uevent.c @@ -165,7 +165,7 @@ int kobject_uevent_env(struct kobject *kobj, enum kobject_action action, /* keys passed in from the caller */ if (envp_ext) { for (i = 0; envp_ext[i]; i++) { - retval = add_uevent_var(env, envp_ext[i]); + retval = add_uevent_var(env, "%s", envp_ext[i]); if (retval) goto exit; } |