diff options
| author | J. Bruce Fields <bfields@redhat.com> | 2013-08-23 23:26:28 +0200 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2013-09-06 17:45:58 +0200 |
| commit | d4a516560fc96a9d486a9939bcb567e3fdce8f49 (patch) | |
| tree | b7cf4d198b901d81b8403667f1bda1f2329b48c7 | |
| parent | rpc: fix huge kmalloc's in gss-proxy (diff) | |
| download | linux-d4a516560fc96a9d486a9939bcb567e3fdce8f49.tar.xz linux-d4a516560fc96a9d486a9939bcb567e3fdce8f49.zip | |
rpc: let xdr layer allocate gssproxy receieve pages
In theory the linux cred in a gssproxy reply can include up to
NGROUPS_MAX data, 256K of data. In the common case we expect it to be
shorter. So do as the nfsv3 ACL code does and let the xdr code allocate
the pages as they come in, instead of allocating a lot of pages that
won't typically be used.
Tested-by: Simo Sorce <simo@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
| -rw-r--r-- | net/sunrpc/auth_gss/gss_rpc_upcall.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/net/sunrpc/auth_gss/gss_rpc_upcall.c b/net/sunrpc/auth_gss/gss_rpc_upcall.c index be95af3d1058..f1eb0d16666c 100644 --- a/net/sunrpc/auth_gss/gss_rpc_upcall.c +++ b/net/sunrpc/auth_gss/gss_rpc_upcall.c @@ -223,18 +223,14 @@ static void gssp_free_receive_pages(struct gssx_arg_accept_sec_context *arg) static int gssp_alloc_receive_pages(struct gssx_arg_accept_sec_context *arg) { - int i; - arg->npages = DIV_ROUND_UP(NGROUPS_MAX * 4, PAGE_SIZE); arg->pages = kzalloc(arg->npages * sizeof(struct page *), GFP_KERNEL); - - for (i=0; i < arg->npages; i++) { - arg->pages[i] = alloc_page(GFP_KERNEL); - if (arg->pages[i] == NULL) { - gssp_free_receive_pages(arg); - return -ENOMEM; - } - } + /* + * XXX: actual pages are allocated by xdr layer in + * xdr_partial_copy_from_skb. + */ + if (!arg->pages) + return -ENOMEM; return 0; } |