diff options
author | Wang Chen <wangchen@cn.fujitsu.com> | 2008-06-24 10:59:02 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-07-22 06:55:00 +0200 |
commit | 0ad1d6f37cc3bb234c6e7ae30e40d1d40b9aa258 (patch) | |
tree | 148158aab527eafbc2f4fc841cf40e1a7730814b | |
parent | sysfs-rules.txt: reword API stability statement (diff) | |
download | linux-0ad1d6f37cc3bb234c6e7ae30e40d1d40b9aa258.tar.xz linux-0ad1d6f37cc3bb234c6e7ae30e40d1d40b9aa258.zip |
kobject: Transmit return value of call_usermodehelper() to caller
kobject_uevent_env() drops the return value of call_usermodehelper().
It will make upper caller, such as dm_send_uevents(), to lose error
information.
BTW, Previously kobject_uevent_env() transmitted return of
call_usermodehelper() to callers, but
commit 5f123fbd80f4f788554636f02bf73e40f914e0d6
"[PATCH] merge kobject_uevent and kobject_hotplug" removed it.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Cc: Kay Sievers <kay.sievers@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | lib/kobject_uevent.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 2fa545a63160..9f8d599459d1 100644 --- a/lib/kobject_uevent.c +++ b/lib/kobject_uevent.c @@ -245,7 +245,8 @@ int kobject_uevent_env(struct kobject *kobj, enum kobject_action action, if (retval) goto exit; - call_usermodehelper(argv[0], argv, env->envp, UMH_WAIT_EXEC); + retval = call_usermodehelper(argv[0], argv, + env->envp, UMH_WAIT_EXEC); } exit: |