diff options
| author | Krzysztof Kozlowski <k.kozlowski@samsung.com> | 2014-11-03 15:07:05 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2014-11-03 15:36:02 +0100 |
| commit | ca0c37a0b489bb14bf3e1549e7a8d0c9a17f4919 (patch) | |
| tree | c76c7b2f6da2e3cf76e32397daa9cd6bed826470 | |
| parent | Linux 3.18-rc1 (diff) | |
| download | linux-ca0c37a0b489bb14bf3e1549e7a8d0c9a17f4919.tar.xz linux-ca0c37a0b489bb14bf3e1549e7a8d0c9a17f4919.zip | |
regulator: max77693: Fix use of uninitialized regulator config
Driver allocated on stack struct regulator_config but didn't initialize
it fully. Few fields (driver_data, ena_gpio) were left untouched. This
lead to using random ena_gpio values as GPIOs for max77693 regulators.
On occasion these values could match real GPIO numbers leading to
interfering with other drivers and to unsuccessful enable/disable of
regulator.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 80b022e29bfd ("regulator: max77693: Add max77693 regualtor driver.")
Cc: <stable@vger.kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/max77693.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/max77693.c b/drivers/regulator/max77693.c index c67ff05fc1dd..d158f71fa128 100644 --- a/drivers/regulator/max77693.c +++ b/drivers/regulator/max77693.c @@ -227,7 +227,7 @@ static int max77693_pmic_probe(struct platform_device *pdev) struct max77693_dev *iodev = dev_get_drvdata(pdev->dev.parent); struct max77693_regulator_data *rdata = NULL; int num_rdata, i; - struct regulator_config config; + struct regulator_config config = { }; num_rdata = max77693_pmic_init_rdata(&pdev->dev, &rdata); if (!rdata || num_rdata <= 0) { |