diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2016-07-18 22:02:47 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-07-20 04:22:38 +0200 |
| commit | cbce91cad4ee39070bf3c7873767194e4be88e16 (patch) | |
| tree | 9b02db867158fb2c3bff4a19d62a19efacd5fec0 | |
| parent | Merge branch 'frag-udp-tunneled-skbs' (diff) | |
| download | linux-cbce91cad4ee39070bf3c7873767194e4be88e16.tar.xz linux-cbce91cad4ee39070bf3c7873767194e4be88e16.zip | |
bnxt_en: Remove locking around txr->dev_state
txr->dev_state was not consistently manipulated with the acquisition of
the per-queue lock, after further inspection the lock does not seem
necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0.
Reported-by: coverity (CID 1339583)
Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index b55eef25b943..8a0165b0b684 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -4930,9 +4930,7 @@ static void bnxt_tx_disable(struct bnxt *bp) for (i = 0; i < bp->tx_nr_rings; i++) { txr = &bp->tx_ring[i]; txq = netdev_get_tx_queue(bp->dev, i); - __netif_tx_lock(txq, smp_processor_id()); txr->dev_state = BNXT_DEV_STATE_CLOSING; - __netif_tx_unlock(txq); } } /* Stop all TX queues */ |