diff options
| author | Mike Turquette <mturquette@linaro.org> | 2012-03-27 01:15:52 +0200 |
|---|---|---|
| committer | Mike Turquette <mturquette@linaro.org> | 2012-04-25 01:37:38 +0200 |
| commit | d4d7e3ddc76c5ae3b4fbd15cb6f30aa78c28d788 (patch) | |
| tree | 419f45ad3531d0f1031096f55125c59fa6d065af | |
| parent | clk: core: clk_calc_new_rates handles NULL parents (diff) | |
| download | linux-d4d7e3ddc76c5ae3b4fbd15cb6f30aa78c28d788.tar.xz linux-d4d7e3ddc76c5ae3b4fbd15cb6f30aa78c28d788.zip | |
clk: core: enforce clk_ops consistency
Documentation/clk.txt has some handsome ASCII art outlining which
clk_ops are mandatory for a given clock, given the capability of the
hardware. Enforce those mandates with sanity checks in __clk_init.
Signed-off-by: Mike Turquette <mturquette@linaro.org>
| -rw-r--r-- | drivers/clk/clk.c | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index d83a9e09e1bf..9924aec17aad 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1202,6 +1202,20 @@ void __clk_init(struct device *dev, struct clk *clk) if (__clk_lookup(clk->name)) goto out; + /* check that clk_ops are sane. See Documentation/clk.txt */ + if (clk->ops->set_rate && + !(clk->ops->round_rate && clk->ops->recalc_rate)) { + pr_warning("%s: %s must implement .round_rate & .recalc_rate\n", + __func__, clk->name); + goto out; + } + + if (clk->ops->set_parent && !clk->ops->get_parent) { + pr_warning("%s: %s must implement .get_parent & .set_parent\n", + __func__, clk->name); + goto out; + } + /* throw a WARN if any entries in parent_names are NULL */ for (i = 0; i < clk->num_parents; i++) WARN(!clk->parent_names[i], |