summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2020-04-23 14:13:10 +0200
committerPaolo Bonzini <pbonzini@redhat.com>2020-05-13 18:14:45 +0200
commit221e761090b4ffadf41acaca1e1f6dd97d84ef4f (patch)
treee45e99167f3366c3ca51d451fbdc70508c993e7d
parentKVM: nSVM: Report interrupts as allowed when in L2 and exit-on-interrupt is set (diff)
downloadlinux-221e761090b4ffadf41acaca1e1f6dd97d84ef4f.tar.xz
linux-221e761090b4ffadf41acaca1e1f6dd97d84ef4f.zip
KVM: nSVM: Preserve IRQ/NMI/SMI priority irrespective of exiting behavior
Short circuit vmx_check_nested_events() if an unblocked IRQ/NMI/SMI is pending and needs to be injected into L2, priority between coincident events is not dependent on exiting behavior. Fixes: b518ba9fa691 ("KVM: nSVM: implement check_nested_events for interrupts") Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r--arch/x86/kvm/svm/nested.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c
index 9c813e08e2cf..712db507c819 100644
--- a/arch/x86/kvm/svm/nested.c
+++ b/arch/x86/kvm/svm/nested.c
@@ -835,23 +835,29 @@ static int svm_check_nested_events(struct kvm_vcpu *vcpu)
kvm_event_needs_reinjection(vcpu) || svm->nested.exit_required ||
svm->nested.nested_run_pending;
- if (vcpu->arch.smi_pending && nested_exit_on_smi(svm)) {
+ if (vcpu->arch.smi_pending && !svm_smi_blocked(vcpu)) {
if (block_nested_events)
return -EBUSY;
+ if (!nested_exit_on_smi(svm))
+ return 0;
nested_svm_smi(svm);
return 0;
}
- if (vcpu->arch.nmi_pending && nested_exit_on_nmi(svm)) {
+ if (vcpu->arch.nmi_pending && !svm_nmi_blocked(vcpu)) {
if (block_nested_events)
return -EBUSY;
+ if (!nested_exit_on_nmi(svm))
+ return 0;
nested_svm_nmi(svm);
return 0;
}
- if (kvm_cpu_has_interrupt(vcpu) && nested_exit_on_intr(svm)) {
+ if (kvm_cpu_has_interrupt(vcpu) && !svm_interrupt_blocked(vcpu)) {
if (block_nested_events)
return -EBUSY;
+ if (!nested_exit_on_intr(svm))
+ return 0;
nested_svm_intr(svm);
return 0;
}