diff options
| author | Zenghui Yu <yuzenghui@huawei.com> | 2019-07-27 08:14:22 +0200 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2019-08-20 11:34:34 +0200 |
| commit | 342be1068d9b5b1fd364d270b4f731764e23de2b (patch) | |
| tree | de023c5b4ae2309539f764a68390f150aa912cb3 | |
| parent | irqchip/gic-v3: Add quirks for HIP06/07 invalid GICD_TYPER erratum 161010803 (diff) | |
| download | linux-342be1068d9b5b1fd364d270b4f731764e23de2b.tar.xz linux-342be1068d9b5b1fd364d270b4f731764e23de2b.zip | |
irqchip/gic-v3-its: Remove the redundant set_bit for lpi_map
We try to find a free LPI region in device's lpi_map and allocate them
(set them to 1) when we want to allocate LPIs for this device. This is
what bitmap_find_free_region() has done for us. The following set_bit
is redundant and a bit confusing (since we only set_bit against the first
allocated LPI idx). Remove it, and make the set_bit explicit by comment.
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
| -rw-r--r-- | drivers/irqchip/irq-gic-v3-its.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 8eeb0e284896..9380aa43493d 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -2464,6 +2464,7 @@ static int its_alloc_device_irq(struct its_device *dev, int nvecs, irq_hw_number { int idx; + /* Find a free LPI region in lpi_map and allocate them. */ idx = bitmap_find_free_region(dev->event_map.lpi_map, dev->event_map.nr_lpis, get_count_order(nvecs)); @@ -2471,7 +2472,6 @@ static int its_alloc_device_irq(struct its_device *dev, int nvecs, irq_hw_number return -ENOSPC; *hwirq = dev->event_map.lpi_base + idx; - set_bit(idx, dev->event_map.lpi_map); return 0; } |