diff options
| author | Johannes Berg <johannes@sipsolutions.net> | 2008-05-04 05:56:42 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-05-04 05:56:42 +0200 |
| commit | c8005785102e5b67ecf213f06a3d6c001f6f8cb4 (patch) | |
| tree | f2c46bd894991379039f30da5d1a1d88e68c601c | |
| parent | sch_htb: remove from event queue in htb_parent_to_leaf() (diff) | |
| download | linux-c8005785102e5b67ecf213f06a3d6c001f6f8cb4.tar.xz linux-c8005785102e5b67ecf213f06a3d6c001f6f8cb4.zip | |
net: Fix useless comment reference loop.
include/linux/skbuff.h says:
/* These elements must be at the end, see alloc_skb() for details. */
net/core/skbuff.c says:
* See comment in sk_buff definition, just before the 'tail' member
This patch contains my guess as to the actual reason rather than a
dead comment reference loop.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/skbuff.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 4fe605fa6f8a..5c459f2b7985 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -200,7 +200,9 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask, goto nodata; /* - * See comment in sk_buff definition, just before the 'tail' member + * Only clear those fields we need to clear, not those that we will + * actually initialise below. Hence, don't put any more fields after + * the tail pointer in struct sk_buff! */ memset(skb, 0, offsetof(struct sk_buff, tail)); skb->truesize = size + sizeof(struct sk_buff); |