summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjorn Helgaas <bhelgaas@google.com>2012-06-21 00:41:16 +0200
committerBjorn Helgaas <bhelgaas@google.com>2012-06-21 01:28:53 +0200
commit809a3bf9f34cb6d0c0383b31b3495fa1ed3508a6 (patch)
treebf12b30a6c9c717cafe158d80e2df16b56004dce
parentPCI: acpiphp: check whether _ADR evaluation succeeded (diff)
downloadlinux-809a3bf9f34cb6d0c0383b31b3495fa1ed3508a6.tar.xz
linux-809a3bf9f34cb6d0c0383b31b3495fa1ed3508a6.zip
PCI: remove useless pcix_set_mmrbc() dev->bus check
For a valid pci_dev, dev->bus != NULL always, so remove this unnecessary test. Found by Coverity (CID 101680). Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
-rw-r--r--drivers/pci/pci.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index b9e93cf1eb40..7f1310e58534 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -3395,8 +3395,7 @@ int pcix_set_mmrbc(struct pci_dev *dev, int mmrbc)
o = (cmd & PCI_X_CMD_MAX_READ) >> 2;
if (o != v) {
- if (v > o && dev->bus &&
- (dev->bus->bus_flags & PCI_BUS_FLAGS_NO_MMRBC))
+ if (v > o && (dev->bus->bus_flags & PCI_BUS_FLAGS_NO_MMRBC))
return -EIO;
cmd &= ~PCI_X_CMD_MAX_READ;