summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabio Estevam <fabio.estevam@freescale.com>2014-12-04 14:15:47 +0100
committerMark Brown <broonie@kernel.org>2014-12-04 23:43:56 +0100
commit75c410884aff0c502dcb34cc58997e67e9b61e5f (patch)
treeb89e2d2d7953c092d8b0e6a50737e27ea04da0c9
parentspi: fsl-espi: add (un)prepare_transfer_hardware calls to save power if SPI i... (diff)
downloadlinux-75c410884aff0c502dcb34cc58997e67e9b61e5f.tar.xz
linux-75c410884aff0c502dcb34cc58997e67e9b61e5f.zip
spi: spi-fsl-spi: Return an error code in fsl_spi_do_one_msg()
Since commit c592becbe704127 ("spi: fsl-(e)spi: migrate to generic master queueing") the function fsl_spi_do_one_msg() is not void anymore, so return an error code to avoid the following buid warning: drivers/spi/spi-fsl-spi.c: In function 'fsl_spi_do_one_msg': >> drivers/spi/spi-fsl-spi.c:374:4: warning: 'return' with no value, in function returning non-void [-Wreturn-type] return; ^ Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--drivers/spi/spi-fsl-spi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c
index 6b94428a0223..5e02c1f3e145 100644
--- a/drivers/spi/spi-fsl-spi.c
+++ b/drivers/spi/spi-fsl-spi.c
@@ -371,7 +371,7 @@ static int fsl_spi_do_one_msg(struct spi_master *master,
status = -EINVAL;
dev_err(&spi->dev,
"bits_per_word/speed_hz should be same for the same SPI transfer\n");
- return;
+ return -EINVAL;
}
}