diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-10-23 13:22:32 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2020-12-17 19:30:32 +0100 |
| commit | bc18546bf68e47996a359d2533168d5770a22024 (patch) | |
| tree | 6662d764d18e9b3a5f9b59aea754a10c4b7f5cec | |
| parent | ext4: check for invalid block size early when mounting a file system (diff) | |
| download | linux-bc18546bf68e47996a359d2533168d5770a22024.tar.xz linux-bc18546bf68e47996a359d2533168d5770a22024.zip | |
ext4: fix an IS_ERR() vs NULL check
The ext4_find_extent() function never returns NULL, it returns error
pointers.
Fixes: 44059e503b03 ("ext4: fast commit recovery path")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20201023112232.GB282278@mwanda
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
| -rw-r--r-- | fs/ext4/extents.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 90ba74c14694..3960b7ec3ab7 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -5815,8 +5815,8 @@ int ext4_ext_replay_update_ex(struct inode *inode, ext4_lblk_t start, int ret; path = ext4_find_extent(inode, start, NULL, 0); - if (!path) - return -EINVAL; + if (IS_ERR(path)) + return PTR_ERR(path); ex = path[path->p_depth].p_ext; if (!ex) { ret = -EFSCORRUPTED; |