diff options
| author | Jeff Mahoney <jeffm@suse.com> | 2016-12-20 19:28:28 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2017-01-03 15:14:21 +0100 |
| commit | d0280996437081dd12ed1e982ac8aeaa62835ec4 (patch) | |
| tree | 9c1e103ecde5541b14903fa7f08630c5ebda84e6 | |
| parent | btrfs: fix error handling when run_delayed_extent_op fails (diff) | |
| download | linux-d0280996437081dd12ed1e982ac8aeaa62835ec4.tar.xz linux-d0280996437081dd12ed1e982ac8aeaa62835ec4.zip | |
btrfs: fix locking when we put back a delayed ref that's too new
In __btrfs_run_delayed_refs, when we put back a delayed ref that's too
new, we have already dropped the lock on locked_ref when we set
->processing = 0.
This patch keeps the lock to cover that assignment.
Fixes: d7df2c796d7 (Btrfs: attach delayed ref updates to delayed ref heads)
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/extent-tree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 5366e50c84c6..ac7e6713033c 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -2522,11 +2522,11 @@ static noinline int __btrfs_run_delayed_refs(struct btrfs_trans_handle *trans, if (ref && ref->seq && btrfs_check_delayed_seq(fs_info, delayed_refs, ref->seq)) { spin_unlock(&locked_ref->lock); - btrfs_delayed_ref_unlock(locked_ref); spin_lock(&delayed_refs->lock); locked_ref->processing = 0; delayed_refs->num_heads_ready++; spin_unlock(&delayed_refs->lock); + btrfs_delayed_ref_unlock(locked_ref); locked_ref = NULL; cond_resched(); count++; |