summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJérôme Pouiller <jerome.pouiller@silabs.com>2020-10-19 18:06:04 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-10-27 13:23:59 +0100
commitdf5fbca677c916d1959f814b41b841b65e450027 (patch)
treef24967088fb7216a11963a9bb992d59c905f46c9
parentstaging: wfx: fix use of uninitialized pointer (diff)
downloadlinux-df5fbca677c916d1959f814b41b841b65e450027.tar.xz
linux-df5fbca677c916d1959f814b41b841b65e450027.zip
staging: wfx: fix test on return value of gpiod_get_value()
The commit 8522d62e6bca ("staging: wfx: gpiod_get_value() can return an error") has changed the way the driver test the value returned by gpiod_get_value(). The new code was wrong. Fixes: 8522d62e6bca ("staging: wfx: gpiod_get_value() can return an error") Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20201019160604.1609180-2-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/wfx/bh.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c
index 2ffa587aefaa..ed53d0b45592 100644
--- a/drivers/staging/wfx/bh.c
+++ b/drivers/staging/wfx/bh.c
@@ -21,7 +21,7 @@ static void device_wakeup(struct wfx_dev *wdev)
if (!wdev->pdata.gpio_wakeup)
return;
- if (gpiod_get_value_cansleep(wdev->pdata.gpio_wakeup) >= 0)
+ if (gpiod_get_value_cansleep(wdev->pdata.gpio_wakeup) > 0)
return;
if (wfx_api_older_than(wdev, 1, 4)) {