summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2021-03-29 08:08:01 +0200
committerMika Westerberg <mika.westerberg@linux.intel.com>2021-03-30 12:38:10 +0200
commit08fe7ae1857080f5075df5ac7fef2ecd4e289117 (patch)
tree3cb7e14240e814cc04379132a6c6da31a726faed
parentthunderbolt: Fix a leak in tb_retimer_add() (diff)
downloadlinux-08fe7ae1857080f5075df5ac7fef2ecd4e289117.tar.xz
linux-08fe7ae1857080f5075df5ac7fef2ecd4e289117.zip
thunderbolt: Fix off by one in tb_port_find_retimer()
This array uses 1-based indexing so it corrupts memory one element beyond of the array. Fix it by making the array one element larger. Fixes: dacb12877d92 ("thunderbolt: Add support for on-board retimers") Cc: stable@vger.kernel.org Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
-rw-r--r--drivers/thunderbolt/retimer.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/thunderbolt/retimer.c b/drivers/thunderbolt/retimer.c
index 7a5d61604c8b..c44fad2b9fbb 100644
--- a/drivers/thunderbolt/retimer.c
+++ b/drivers/thunderbolt/retimer.c
@@ -406,7 +406,7 @@ static struct tb_retimer *tb_port_find_retimer(struct tb_port *port, u8 index)
*/
int tb_retimer_scan(struct tb_port *port)
{
- u32 status[TB_MAX_RETIMER_INDEX] = {};
+ u32 status[TB_MAX_RETIMER_INDEX + 1] = {};
int ret, i, last_idx = 0;
if (!port->cap_usb4)