summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2016-01-13 13:21:17 +0100
committerDavid Sterba <dsterba@suse.com>2016-01-15 19:27:28 +0100
commit0dc924c5f2a3c4d999e12feaccee5f970cea1315 (patch)
treef8bbd1998deb74a0c3253c24b7bd1286b2afe6d9
parentbtrfs: fix iterator with update error in backref.c (diff)
downloadlinux-0dc924c5f2a3c4d999e12feaccee5f970cea1315.tar.xz
linux-0dc924c5f2a3c4d999e12feaccee5f970cea1315.zip
Btrfs: clean up an error code in btrfs_init_space_info()
If we return 1 here, then the caller treats it as an error and returns -EINVAL. It causes a static checker warning to treat positive returns as an error. Fixes: 1aba86d67f34 ('Btrfs: fix easily get into ENOSPC in mixed case') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David Sterba <dsterba@suse.com>
-rw-r--r--fs/btrfs/extent-tree.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 8c912894a5bd..9d70330c6ebf 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -10509,7 +10509,7 @@ int btrfs_init_space_info(struct btrfs_fs_info *fs_info)
disk_super = fs_info->super_copy;
if (!btrfs_super_root(disk_super))
- return 1;
+ return -EINVAL;
features = btrfs_super_incompat_flags(disk_super);
if (features & BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS)