diff options
| author | Andrew Scull <ascull@google.com> | 2021-03-18 15:33:09 +0100 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2021-04-01 10:54:37 +0200 |
| commit | 5b8be5d875a996776708ba174fcd08c8bcd721a5 (patch) | |
| tree | 609725de80512fb7dff50b84767a87addbfd0444 | |
| parent | bug: Factor out a getter for a bug's file line (diff) | |
| download | linux-5b8be5d875a996776708ba174fcd08c8bcd721a5.tar.xz linux-5b8be5d875a996776708ba174fcd08c8bcd721a5.zip | |
bug: Assign values once in bug_get_file_line()
Set bug_get_file_line()'s output parameter values directly rather than
first nullifying them and then conditionally setting new values.
Signed-off-by: Andrew Scull <ascull@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Acked-by: Will Deacon <will@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210318143311.839894-4-ascull@google.com
| -rw-r--r-- | lib/bug.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/bug.c b/lib/bug.c index e65398082cbc..45a0584f6541 100644 --- a/lib/bug.c +++ b/lib/bug.c @@ -130,9 +130,6 @@ static inline struct bug_entry *module_find_bug(unsigned long bugaddr) void bug_get_file_line(struct bug_entry *bug, const char **file, unsigned int *line) { - *file = NULL; - *line = 0; - #ifdef CONFIG_DEBUG_BUGVERBOSE #ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS *file = bug->file; @@ -140,6 +137,9 @@ void bug_get_file_line(struct bug_entry *bug, const char **file, *file = (const char *)bug + bug->file_disp; #endif *line = bug->line; +#else + *file = NULL; + *line = 0; #endif } |