summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>2007-10-19 08:39:14 +0200
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-10-19 20:53:33 +0200
commit22124c9999f00340b062fff740db30187bf18454 (patch)
treee3486a4965def48c38355ce7365ee84d6e89618b
parentps3av: remove unused fields in ps3av_monitor_quirks (diff)
downloadlinux-22124c9999f00340b062fff740db30187bf18454.tar.xz
linux-22124c9999f00340b062fff740db30187bf18454.zip
kmap leak fix for x86_32 kdump
copy_oldmem_page should not return leaving a page frame from the previous kernel mapped. Signed-off-by: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp> Acked-by: Vivek Goyal <vgoyal@in.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--arch/x86/kernel/crash_dump_32.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/x86/kernel/crash_dump_32.c b/arch/x86/kernel/crash_dump_32.c
index 32e75d0731a9..72d0c56c1b48 100644
--- a/arch/x86/kernel/crash_dump_32.c
+++ b/arch/x86/kernel/crash_dump_32.c
@@ -47,6 +47,7 @@ ssize_t copy_oldmem_page(unsigned long pfn, char *buf,
if (!kdump_buf_page) {
printk(KERN_WARNING "Kdump: Kdump buffer page not"
" allocated\n");
+ kunmap_atomic(vaddr, KM_PTE0);
return -EFAULT;
}
copy_page(kdump_buf_page, vaddr);