diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2018-02-22 02:08:01 +0100 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2018-02-26 21:32:42 +0100 |
| commit | 230f5a8969d8345fc9bbe3683f068246cf1be4b8 (patch) | |
| tree | b6df1cb9d5379fd341c1d179ebae744e96df9ebb | |
| parent | dax: ->direct_access does not sleep anymore (diff) | |
| download | linux-230f5a8969d8345fc9bbe3683f068246cf1be4b8.tar.xz linux-230f5a8969d8345fc9bbe3683f068246cf1be4b8.zip | |
dax: fix vma_is_fsdax() helper
Gerd reports that ->i_mode may contain other bits besides S_IFCHR. Use
S_ISCHR() instead. Otherwise, get_user_pages_longterm() may fail on
device-dax instances when those are meant to be explicitly allowed.
Fixes: 2bb6d2837083 ("mm: introduce get_user_pages_longterm")
Cc: <stable@vger.kernel.org>
Reported-by: Gerd Rausch <gerd.rausch@oracle.com>
Acked-by: Jane Chu <jane.chu@oracle.com>
Reported-by: Haozhong Zhang <haozhong.zhang@intel.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
| -rw-r--r-- | include/linux/fs.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/fs.h b/include/linux/fs.h index 2a815560fda0..79c413985305 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3198,7 +3198,7 @@ static inline bool vma_is_fsdax(struct vm_area_struct *vma) if (!vma_is_dax(vma)) return false; inode = file_inode(vma->vm_file); - if (inode->i_mode == S_IFCHR) + if (S_ISCHR(inode->i_mode)) return false; /* device-dax */ return true; } |