diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2009-02-20 09:52:19 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-02-20 09:52:19 +0100 |
| commit | 2cf0dbed27af3f827a96db98c2535002902f6af0 (patch) | |
| tree | c5b53517aa3101a881477255de184ab0e65b8212 | |
| parent | smsc9420: handle magic field of ethtool_eeprom (diff) | |
| download | linux-2cf0dbed27af3f827a96db98c2535002902f6af0.tar.xz linux-2cf0dbed27af3f827a96db98c2535002902f6af0.zip | |
SMSC: timeout reaches -1
With a postfix decrement timeouts will reach -1 rather than 0, so
the error path does not appear.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/smsc911x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c index 783c1a7b869e..9a78daec2fe9 100644 --- a/drivers/net/smsc911x.c +++ b/drivers/net/smsc911x.c @@ -1624,7 +1624,7 @@ static int smsc911x_eeprom_send_cmd(struct smsc911x_data *pdata, u32 op) do { msleep(1); e2cmd = smsc911x_reg_read(pdata, E2P_CMD); - } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (timeout--)); + } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (--timeout)); if (!timeout) { SMSC_TRACE(DRV, "TIMED OUT"); |