diff options
author | Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2019-07-26 01:40:03 +0200 |
---|---|---|
committer | Vinod Koul <vkoul@kernel.org> | 2019-08-02 14:06:47 +0200 |
commit | 68acd85996f6456ad95b458f19bc7309ed530a4b (patch) | |
tree | 58b08683b095126fef70d12f428c85f1d15798b7 | |
parent | soundwire: intel: remove BIOS work-arounds (diff) | |
download | linux-68acd85996f6456ad95b458f19bc7309ed530a4b.tar.xz linux-68acd85996f6456ad95b458f19bc7309ed530a4b.zip |
soundwire: cadence_master: simplify bus clash interrupt clear
The bus clash interrupts are generated when the status is one, and
also cleared by writing a one. It's overkill/useless to use an OR when
the bit is already set.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20190725234032.21152-12-pierre-louis.bossart@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
-rw-r--r-- | drivers/soundwire/cadence_master.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index ff4badc9b3de..dc2d7227a068 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -578,7 +578,6 @@ irqreturn_t sdw_cdns_irq(int irq, void *dev_id) if (int_status & CDNS_MCP_INT_CTRL_CLASH) { /* Slave is driving bit slot during control word */ dev_err_ratelimited(cdns->dev, "Bus clash for control word\n"); - int_status |= CDNS_MCP_INT_CTRL_CLASH; } if (int_status & CDNS_MCP_INT_DATA_CLASH) { @@ -587,7 +586,6 @@ irqreturn_t sdw_cdns_irq(int irq, void *dev_id) * ownership of data bits or Slave gone bonkers */ dev_err_ratelimited(cdns->dev, "Bus clash for data word\n"); - int_status |= CDNS_MCP_INT_DATA_CLASH; } if (int_status & CDNS_MCP_INT_SLAVE_MASK) { |