diff options
| author | Chris Mason <clm@fb.com> | 2014-11-04 15:59:04 +0100 |
|---|---|---|
| committer | Chris Mason <clm@fb.com> | 2014-11-04 15:59:04 +0100 |
| commit | 6e5aafb27419f32575b27ef9d6a31e5d54661aca (patch) | |
| tree | eb307ad73bfd843e382a9a0f94d81e32f6eb5df1 | |
| parent | Btrfs: fix race that makes btrfs_lookup_extent_info miss skinny extent items (diff) | |
| download | linux-6e5aafb27419f32575b27ef9d6a31e5d54661aca.tar.xz linux-6e5aafb27419f32575b27ef9d6a31e5d54661aca.zip | |
Btrfs: fix kfree on list_head in btrfs_lookup_csums_range error cleanup
If we hit any errors in btrfs_lookup_csums_range, we'll loop through all
the csums we allocate and free them. But the code was using list_entry
incorrectly, and ended up trying to free the on-stack list_head instead.
This bug came from commit 0678b6185
btrfs: Don't BUG_ON kzalloc error in btrfs_lookup_csums_range()
Signed-off-by: Chris Mason <clm@fb.com>
Reported-by: Erik Berg <btrfs@slipsprogrammoer.no>
cc: stable@vger.kernel.org # 3.3 or newer
| -rw-r--r-- | fs/btrfs/file-item.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c index 783a94355efd..84a2d1868271 100644 --- a/fs/btrfs/file-item.c +++ b/fs/btrfs/file-item.c @@ -413,7 +413,7 @@ int btrfs_lookup_csums_range(struct btrfs_root *root, u64 start, u64 end, ret = 0; fail: while (ret < 0 && !list_empty(&tmplist)) { - sums = list_entry(&tmplist, struct btrfs_ordered_sum, list); + sums = list_entry(tmplist.next, struct btrfs_ordered_sum, list); list_del(&sums->list); kfree(sums); } |