diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-04-17 08:20:30 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-04-22 15:10:20 +0200 |
| commit | 8c93c40080bda655295ae3673dfb26dee34d9d49 (patch) | |
| tree | dadf1fde95e496b71eecbfab88a0c7508cf37cb6 | |
| parent | [media] cx88: Fix unsafe locking in suspend-resume (diff) | |
| download | linux-8c93c40080bda655295ae3673dfb26dee34d9d49.tar.xz linux-8c93c40080bda655295ae3673dfb26dee34d9d49.zip | |
[media] go7007: dubious one-bit signed bitfields
Because they're signed, "is_video" and "is_audio" can be 0 and -1
instead of 0 and 1 as intended. It doesn't cause a bug, but it makes
Sparse complain:
drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield
drivers/staging/media/go7007/go7007-priv.h:95:31: error: dubious one-bit signed bitfield
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| -rw-r--r-- | drivers/staging/media/go7007/go7007-priv.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/media/go7007/go7007-priv.h b/drivers/staging/media/go7007/go7007-priv.h index 8bde187e4f90..6e16af720504 100644 --- a/drivers/staging/media/go7007/go7007-priv.h +++ b/drivers/staging/media/go7007/go7007-priv.h @@ -91,8 +91,8 @@ struct go7007_board_info { int num_i2c_devs; struct go_i2c { const char *type; - int is_video:1; - int is_audio:1; + unsigned int is_video:1; + unsigned int is_audio:1; int addr; u32 flags; } i2c_devs[5]; |