diff options
| author | Vasundhara Volam <vasundhara-v.volam@broadcom.com> | 2020-08-26 07:08:33 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-08-26 16:19:03 +0200 |
| commit | dbbfa96ad920c50d58bcaefa57f5f33ceef9d00e (patch) | |
| tree | 1e9e6a573593b7caf2fbadc0732c25799fb3ec5e | |
| parent | bnxt_en: Don't query FW when netif_running() is false. (diff) | |
| download | linux-dbbfa96ad920c50d58bcaefa57f5f33ceef9d00e.tar.xz linux-dbbfa96ad920c50d58bcaefa57f5f33ceef9d00e.zip | |
bnxt_en: Check for zero dir entries in NVRAM.
If firmware goes into unstable state, HWRM_NVM_GET_DIR_INFO firmware
command may return zero dir entries. Return error in such case to
avoid zero length dma buffer request.
Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 3890c1aaeed6..5d1a0cd0b53e 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -2323,6 +2323,9 @@ static int bnxt_get_nvram_directory(struct net_device *dev, u32 len, u8 *data) if (rc != 0) return rc; + if (!dir_entries || !entry_length) + return -EIO; + /* Insert 2 bytes of directory info (count and size of entries) */ if (len < 2) return -EINVAL; |