diff options
| author | Yicong Yang <yangyicong@hisilicon.com> | 2021-09-15 08:31:58 +0200 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2021-10-14 13:09:58 +0200 |
| commit | f9ec6fea201429b5a3f76319e943989f1a1e25ef (patch) | |
| tree | b60a14bf5ef36bd5c8c37fc14c678d3cf6c82d5b | |
| parent | sched/numa: Fix a few comments (diff) | |
| download | linux-f9ec6fea201429b5a3f76319e943989f1a1e25ef.tar.xz linux-f9ec6fea201429b5a3f76319e943989f1a1e25ef.zip | |
sched/topology: Remove unused numa_distance in cpu_attach_domain()
numa_distance in cpu_attach_domain() is introduced in
commit b5b217346de8 ("sched/topology: Warn when NUMA diameter > 2")
to warn user when NUMA diameter > 2 as we'll misrepresent
the scheduler topology structures at that time. This is
fixed by Barry in commit 585b6d2723dc ("sched/topology: fix the issue
groups don't span domain->span for NUMA diameter > 2") and
numa_distance is unused now. So remove it.
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Barry Song <baohua@kernel.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lore.kernel.org/r/20210915063158.80639-1-yangyicong@hisilicon.com
| -rw-r--r-- | kernel/sched/topology.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index c56faae461d9..5af3edd34d6d 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -688,7 +688,6 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu) { struct rq *rq = cpu_rq(cpu); struct sched_domain *tmp; - int numa_distance = 0; /* Remove the sched domains which do not contribute to scheduling. */ for (tmp = sd; tmp; ) { @@ -732,9 +731,6 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu) } } - for (tmp = sd; tmp; tmp = tmp->parent) - numa_distance += !!(tmp->flags & SD_NUMA); - sched_domain_debug(sd, cpu); rq_attach_root(rq, rd); |