summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLogan Gunthorpe <logang@deltatee.com>2017-07-25 22:57:42 +0200
committerJon Mason <jdmason@kudzu.us>2017-08-01 21:18:59 +0200
commit0eb46345364d7318b11068c46e8a68d5dc10f65e (patch)
tree05bb31a2bc66ed1b746ba3aecfaa89c0106f397b
parentntb: transport shouldn't disable link due to bogus values in SPADs (diff)
downloadlinux-0eb46345364d7318b11068c46e8a68d5dc10f65e.tar.xz
linux-0eb46345364d7318b11068c46e8a68d5dc10f65e.zip
ntb: ntb_test: ensure the link is up before trying to configure the mws
After the link tests, there is a race on one side of the test for the link coming up. It's possible, in some cases, for the test script to write to the 'peer_trans' files before the link has come up. To fix this, we simply use the link event file to ensure both sides see the link as up before continuning. Signed-off-by: Logan Gunthorpe <logang@deltatee.com> Acked-by: Allen Hubbe <Allen.Hubbe@dell.com> Signed-off-by: Jon Mason <jdmason@kudzu.us> Fixes: a9c59ef77458 ("ntb_test: Add a selftest script for the NTB subsystem")
-rwxr-xr-xtools/testing/selftests/ntb/ntb_test.sh4
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
index 1c12b5855e4f..5fc7ad359e21 100755
--- a/tools/testing/selftests/ntb/ntb_test.sh
+++ b/tools/testing/selftests/ntb/ntb_test.sh
@@ -333,6 +333,10 @@ function ntb_tool_tests()
link_test $LOCAL_TOOL $REMOTE_TOOL
link_test $REMOTE_TOOL $LOCAL_TOOL
+ #Ensure the link is up on both sides before continuing
+ write_file Y $LOCAL_TOOL/link_event
+ write_file Y $REMOTE_TOOL/link_event
+
for PEER_TRANS in $(ls $LOCAL_TOOL/peer_trans*); do
PT=$(basename $PEER_TRANS)
write_file $MW_SIZE $LOCAL_TOOL/$PT