summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2019-04-22 19:12:32 +0200
committerGuenter Roeck <linux@roeck-us.net>2019-04-23 15:30:38 +0200
commit212244f76d13bdbb57fa8096a8aa94c5b55c4be5 (patch)
tree2756cc62062a6287aaf37d720ebd11314ee8737e
parentdocs: hwmon: remove the extension from .rst files (diff)
downloadlinux-212244f76d13bdbb57fa8096a8aa94c5b55c4be5.tar.xz
linux-212244f76d13bdbb57fa8096a8aa94c5b55c4be5.zip
hwmon: (max6650) Drop call to thermal_cdev_update
The call to thermal_cdev_update() causes any fan connected to the chip to stop immediately. If the thermal subsystem is not set up to actually handle the chip as cooling device, the remains stopped until is is restarted manually with a write to a sysfs attribute. There is evidence that thermal_cdev_update() should only be called from thermal governors, not from thermal cooling device drivers. Drop the call. Cc: Jean-Francois Dagenais <jeff.dagenais@gmail.com> Tested-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
-rw-r--r--drivers/hwmon/max6650.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c
index e977c2f2d74a..939953240827 100644
--- a/drivers/hwmon/max6650.c
+++ b/drivers/hwmon/max6650.c
@@ -801,8 +801,6 @@ static int max6650_probe(struct i2c_client *client,
dev_warn(&client->dev,
"thermal cooling device register failed: %ld\n",
PTR_ERR(data->cooling_dev));
- else
- thermal_cdev_update(data->cooling_dev);
#endif
return 0;
}