diff options
| author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2015-01-10 00:16:22 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-01-12 22:42:49 +0100 |
| commit | 49c9e7c21af4743f8413cfdce78b551b9d5caad9 (patch) | |
| tree | 4a3676da41a8fec1c01bac61fad12445f19fd4c8 | |
| parent | MAINTAINERS: add me as ibmveth maintainer (diff) | |
| download | linux-49c9e7c21af4743f8413cfdce78b551b9d5caad9.tar.xz linux-49c9e7c21af4743f8413cfdce78b551b9d5caad9.zip | |
usb/kaweth: use GFP_ATOMIC under spin_lock in usb_start_wait_urb()
Commit e4c7f259c5be ("USB: kaweth.c: use GFP_ATOMIC under spin_lock")
makes sure that kaweth_internal_control_msg() allocates memory with GFP_ATOMIC,
but kaweth_internal_control_msg() also calls usb_start_wait_urb()
that still allocates memory with GFP_NOIO.
The patch fixes usb_start_wait_urb() as well.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/kaweth.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index dcb6d33141e0..1e9cdca37014 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -1276,7 +1276,7 @@ static int usb_start_wait_urb(struct urb *urb, int timeout, int* actual_length) awd.done = 0; urb->context = &awd; - status = usb_submit_urb(urb, GFP_NOIO); + status = usb_submit_urb(urb, GFP_ATOMIC); if (status) { // something went wrong usb_free_urb(urb); |