diff options
| author | Dave Jones <davej@redhat.com> | 2013-10-11 02:05:35 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2013-10-12 20:39:49 +0200 |
| commit | 6e4ea8e33b2057b85d75175dd89b93f5e26de3bc (patch) | |
| tree | bc80cddd29e231c4068bfe40fe4f7693c48f65f3 | |
| parent | ext4: fix performance regression in writeback of random writes (diff) | |
| download | linux-6e4ea8e33b2057b85d75175dd89b93f5e26de3bc.tar.xz linux-6e4ea8e33b2057b85d75175dd89b93f5e26de3bc.zip | |
ext4: fix memory leak in xattr
If we take the 2nd retry path in ext4_expand_extra_isize_ea, we
potentionally return from the function without having freed these
allocations. If we don't do the return, we over-write the previous
allocation pointers, so we leak either way.
Spotted with Coverity.
[ Fixed by tytso to set is and bs to NULL after freeing these
pointers, in case in the retry loop we later end up triggering an
error causing a jump to cleanup, at which point we could have a double
free bug. -- Ted ]
Signed-off-by: Dave Jones <davej@fedoraproject.org>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Cc: stable@vger.kernel.org
| -rw-r--r-- | fs/ext4/xattr.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index c081e34f717f..03e9bebba198 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1350,6 +1350,8 @@ retry: s_min_extra_isize) { tried_min_extra_isize++; new_extra_isize = s_min_extra_isize; + kfree(is); is = NULL; + kfree(bs); bs = NULL; goto retry; } error = -1; |