summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSascha Hlusiak <contact@saschahlusiak.de>2009-08-29 08:53:53 +0200
committerDavid S. Miller <davem@davemloft.net>2009-08-29 08:53:53 +0200
commit8945a808f7d5efd21fa9fb6055d2dd7887bdd9d8 (patch)
tree9bf05fb41dec4987c19d51486f4f6ae98f211297
parentnet: ip_rt_send_redirect() optimization (diff)
downloadlinux-8945a808f7d5efd21fa9fb6055d2dd7887bdd9d8.tar.xz
linux-8945a808f7d5efd21fa9fb6055d2dd7887bdd9d8.zip
sit: allow ip fragmentation when using nopmtudisc to fix package loss
if tunnel parameters have frag_off set to IP_DF, pmtudisc on the ipv4 link will be performed by deriving the mtu from the ipv4 link and setting the DF-Flag of the encapsulating IPv4 Header. If fragmentation is needed on the way, the IPv4 pmtu gets adjusted, the ipv6 package will be resent eventually, using the new and lower mtu and everyone is happy. If the frag_off parameter is unset, the mtu for the tunnel will be derived from the tunnel device or the ipv6 pmtu, which might be higher than the ipv4 pmtu. In that case we must allow the fragmentation of the IPv4 packet because the IPv6 mtu wouldn't 'learn' from the adjusted IPv4 pmtu, resulting in frequent icmp_frag_needed and package loss on the IPv6 layer. This patch allows fragmentation when tunnel was created with parameter nopmtudisc, like in ipip/gre tunnels. Signed-off-by: Sascha Hlusiak <contact@saschahlusiak.de> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv6/sit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index d335a306a4db..1d25a4dff0af 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -778,7 +778,7 @@ static int ipip6_tunnel_xmit(struct sk_buff *skb, struct net_device *dev)
iph->version = 4;
iph->ihl = sizeof(struct iphdr)>>2;
if (mtu > IPV6_MIN_MTU)
- iph->frag_off = htons(IP_DF);
+ iph->frag_off = tiph->frag_off;
else
iph->frag_off = 0;