diff options
| author | Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> | 2020-07-17 13:44:57 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-07-20 08:33:44 +0200 |
| commit | b59aeb1a59ccece01f4f0c675d18cfac9cc825fb (patch) | |
| tree | 80871207061c9d242e246c90ec30e8d67387f01b | |
| parent | phy: renesas: rcar-gen3-usb2: move irq registration to init (diff) | |
| download | linux-b59aeb1a59ccece01f4f0c675d18cfac9cc825fb.tar.xz linux-b59aeb1a59ccece01f4f0c675d18cfac9cc825fb.zip | |
phy: renesas: rcar-gen3-usb2: exit if request_irq() failed
To avoid unexpected behaviors, it's better to exit if request_irq()
failed.
Suggested-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/1594986297-12434-3-git-send-email-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/phy/renesas/phy-rcar-gen3-usb2.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c index 5087b7c44d55..e34e4475027c 100644 --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c @@ -419,8 +419,10 @@ static int rcar_gen3_phy_usb2_init(struct phy *p) INIT_WORK(&channel->work, rcar_gen3_phy_usb2_work); ret = request_irq(channel->irq, rcar_gen3_phy_usb2_irq, IRQF_SHARED, dev_name(channel->dev), channel); - if (ret < 0) + if (ret < 0) { dev_err(channel->dev, "No irq handler (%d)\n", channel->irq); + return ret; + } } /* Initialize USB2 part */ |